Skip to content

Skip masking for Kinesis PartitionKey #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 31, 2021
Merged

Skip masking for Kinesis PartitionKey #179

merged 1 commit into from
Jan 31, 2021

Conversation

nirLumigo
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Jan 31, 2021

Codecov Report

Merging #179 (def9079) into master (827a7a9) will increase coverage by 1.24%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #179      +/-   ##
==========================================
+ Coverage   96.21%   97.45%   +1.24%     
==========================================
  Files          11       22      +11     
  Lines         952     1771     +819     
==========================================
+ Hits          916     1726     +810     
- Misses         36       45       +9
Impacted Files Coverage Δ
lumigo_tracer/parsers/parser.py
lumigo_tracer/sync_http/sync_hook.py
lumigo_tracer/parsers/http_data_classes.py
lumigo_tracer/sync_http/handler.py
lumigo_tracer/utils.py
lumigo_tracer/parsers/event_parser.py
lumigo_tracer/parsers/utils.py
lumigo_tracer/extension/main.py 95.83% <0.00%> (ø)
lumigo_tracer/wrappers/redis/redis_wrapper.py 96.36% <0.00%> (ø)
lumigo_tracer/wrappers/pymongo/pymongo_wrapper.py 89.74% <0.00%> (ø)
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0050e7...def9079. Read the comment docs.

@nirLumigo nirLumigo merged commit 30b06fb into master Jan 31, 2021
@nirLumigo nirLumigo deleted the RD-4455-unmask-partition-key branch January 31, 2021 12:52
saartochner-lumigo pushed a commit that referenced this pull request Jan 31, 2021
1.1.146 → 1.1.147. Changes: 30b06fb Skip masking for Kinesis Partitio…
29bbaf7 
…nKey (#179)

a0050e7 layers-table: layers md [skip ci]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@saartochner-lumigo saartochner-lumigo saartochner-lumigo approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nirLumigo @saartochner-lumigo